Isolate access to IElasticClient in ElasticIndexManager #16422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreySurkov I am seeing too many changes here. I think PR #16424 will fix the issue you are having. Can you please check it out? |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
@AndreySurkov are you able to verify that this issue no longer exists in 2.0.0-preview? If so, please close this PR. |
|
@MikeAlhayek Thanks. I verified it. My idea was to refactor part of ES related code to avoid similar problems in future, and limit code that make direct to IElasticSearchClient in single place. But if you are prefer to make fix as simple as it can be it works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16421