Fix footer in darkmode (Lombiq Technologies: NEST-515) #16444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psichorex
changed the title
hishamco
approved these changes
Jul 17, 2024
|
@hishamco please merge PRs, especially for non-maintainers who can't merge their own, after an approve (unless you're waiting for second opinions, of course, but then comment this explicitly and add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dark Theme currently leaves the Footer section's background color with
#f5f5f5which is barely readable.It is also statically defined in
_layout.scssthus it wasn't coming from Bootstrap.Quick change to handle the footer's background color so that it matches with the selected theme.