Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup with saved password #16466

Merged
merged 12 commits into from
Jul 22, 2024
Merged

Conversation

sarahelsaig
Copy link
Contributor

Fixes #16465

@sarahelsaig
Copy link
Contributor Author

The "Check if git has changes" check failed. Is that a problem or just a warning? I mean of course it has changes, I've updates JS assets.

@MikeAlhayek
Copy link
Member

I think you need to run the following command to get the build to work npm install && gulp rebuild. You probably don't have the latest npm packages on your development machine.

@sarahelsaig
Copy link
Contributor Author

Ok, I tried that but I get the following error:
image
I have node v22.0.0 and gulp v5.0.0. Do you know what's the problem?

@sarahelsaig
Copy link
Contributor Author

sarahelsaig commented Jul 22, 2024

Okay, I figured it out. I think Gulp doesn't work with newer versions of Node.js? I had to use nvm install 18 to downgrade my environment to node v18.20.4, then it worked. I've added a note to the docs.
And now the "Validating the Building of Public Assets" workflow passes. 👍

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, very useful!

src/docs/reference/modules/AutoSetup/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/AutoSetup/README.md Outdated Show resolved Hide resolved
@sarahelsaig sarahelsaig requested a review from Piedone July 22, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve setup UX when using a password manager
3 participants