Separate ListPart search into own shape #16749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-easier placement and visibility of search panel. -follow same pattern as other shapes in list part admin. -cleanup unused services in razor view.
MikeAlhayek
reviewed
Sep 18, 2024
src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs
Outdated
Show resolved
Hide resolved
…layDriver.cs Co-authored-by: Mike Alhayek <[email protected]>
MikeAlhayek
requested changes
Sep 18, 2024
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartDetailAdminSearchPanel.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartDetailAdmin.cshtml
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartDetailAdminSearchPanel.cshtml
Outdated
Show resolved
Hide resolved
…AdminSearchPanel.cshtml Co-authored-by: Mike Alhayek <[email protected]>
… listpartadmin-search-panel
hishamco
requested changes
Sep 20, 2024
src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartDetailAdminSearchPanel.cshtml
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartNavigationAdmin.cshtml
Outdated
Show resolved
Hide resolved
|
@giannik please react to the changes and request a review again @MikeAlhayek if you have anything else let me know, otherwise I will merge once the changes applied |
…tionAdmin.cshtml Co-authored-by: Hisham Bin Ateya <[email protected]>
…AdminSearchPanel.cshtml Co-authored-by: Hisham Bin Ateya <[email protected]>
…layDriver.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
reviewed
Sep 20, 2024
| var authorizedContentTypeDefinitions = new List<ContentTypeDefinition>(); | ||
| foreach (var contentTypeDefinition in Model.ContainedContentTypeDefinitions) | ||
| { | ||
| if (await AuthorizationService.AuthorizeAsync(User, CommonPermissions.EditContent, await ContentManager.NewAsync(contentTypeDefinition.Name))) |
There was a problem hiding this comment.
Why do we need to add content each time?
MikeAlhayek
requested changes
Sep 20, 2024
src/OrchardCore.Modules/OrchardCore.Lists/Drivers/ListPartDisplayDriver.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartNavigationAdmin.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartNavigationAdmin.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartDetailAdminSearchPanel.cshtml
Outdated
Show resolved
Hide resolved
MikeAlhayek
reviewed
Sep 20, 2024
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartNavigationAdmin.cshtml
Outdated
Show resolved
Hide resolved
MikeAlhayek
changed the title
…AdminSearchPanel.cshtml Co-authored-by: Mike Alhayek <[email protected]>
…layDriver.cs Co-authored-by: Mike Alhayek <[email protected]>
…tionAdmin.cshtml Co-authored-by: Mike Alhayek <[email protected]>
…tionAdmin.cshtml Co-authored-by: Mike Alhayek <[email protected]>
…tionAdmin.cshtml Co-authored-by: Mike Alhayek <[email protected]>
MikeAlhayek
reviewed
Sep 20, 2024
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartDetailAdminSearchPanel.cshtml
Outdated
Show resolved
Hide resolved
…AdminSearchPanel.cshtml
MikeAlhayek
approved these changes
Sep 20, 2024
hishamco
reviewed
Sep 20, 2024
Comment on lines
+9
to
+11
| var dropdownClassList = CultureInfo.CurrentUICulture.IsRightToLeft() | ||
| ? "dropdown-menu dropdown-menu-start" | ||
| : "dropdown-menu"; |
There was a problem hiding this comment.
Just have one question before you nominate me @MikeAlhayek, this time there are 4 spaces before it's by intention or VS formatting?!!
hishamco
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-easier placement and visibility of search panel.
-follow same pattern as other shapes in list part admin.
-cleanup unused services in razor view.