Skip processing of media root path by MediaFileStoreResolverMiddleware #16760
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Sep 19, 2024
src/OrchardCore.Modules/OrchardCore.Media/Services/MediaFileStoreResolverMiddleware.cs
Outdated
Show resolved
Hide resolved
gvkries
reviewed
Sep 19, 2024
src/OrchardCore.Modules/OrchardCore.Media/Services/MediaFileStoreResolverMiddleware.cs
Show resolved
Hide resolved
gvkries
approved these changes
Sep 20, 2024
hishamco
requested changes
Sep 20, 2024
src/OrchardCore.Modules/OrchardCore.Media/Services/MediaFileStoreResolverMiddleware.cs
Show resolved
Hide resolved
…oreResolverMiddleware.cs
hishamco
approved these changes
Sep 20, 2024
|
Thanks, @AndreySurkov for your contribution @all-contributors please add @AndreySurkov for code. |
|
@AndreySurkov already contributed before to code |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone requests root media path like /media or /media/ with OrchardCore.Media.AmazonS3 module enabled then floowing error message writes to log "Error retrieving file from media file store for request path /".
This does not look like exceptional situation so I added a code to skip this handling.