Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More expressive titles in the change log (Lombiq Technologies: OCORE-199) #16773

Merged
merged 9 commits into from
Sep 21, 2024

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Sep 20, 2024

Following up from #16755 (comment).

@MikeAlhayek
Copy link
Member

I still think we should not do this. Our current format groups all the changes that are related to the same feature under one bullet point.

IMO, I think we should still continue to follow the following format:

# Release Version

## Breaking Changes

### Feature Name
- Change 1
- Change 2
- Change 3

## Change Logs

### Feature Name
- Change 1
- Change 2
- Change 3

@Piedone
Copy link
Member Author

Piedone commented Sep 20, 2024

Fine by me, how about now?

src/docs/releases/2.1.0.md Outdated Show resolved Hide resolved
src/docs/releases/2.1.0.md Outdated Show resolved Hide resolved
src/docs/releases/2.1.0.md Outdated Show resolved Hide resolved
Piedone and others added 3 commits September 20, 2024 18:38
@MikeAlhayek
Copy link
Member

@Piedone I would also either move the addition External Authentication feature to New Features section, or add a reference to the new External Authentication feature in the New Features section.

@Piedone
Copy link
Member Author

Piedone commented Sep 20, 2024

I added it at the bottom. However, now the original section above doesn't make sense. So, I moved that under the Users feature, which is the one that actually changed.

src/docs/releases/2.1.0.md Outdated Show resolved Hide resolved
Co-authored-by: Mike Alhayek <[email protected]>
@Piedone Piedone merged commit 3ac03a4 into OrchardCMS:main Sep 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants