Fix ContentPartFIeldDefinition Settings.ToObject Deserialization #16774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests to cover fields
…settings-empty-fix
MikeAlhayek
requested changes
Sep 20, 2024
test/OrchardCore.Tests/Modules/OrchardCore.ContentFields/Settings/DriverTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Modules/OrchardCore.ContentFields/Settings/DriverTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Modules/OrchardCore.ContentFields/Settings/DriverTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Modules/OrchardCore.Search.Elasticsearch/DriverTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Modules/OrchardCore.Search.Elasticsearch/DriverTests.cs
Outdated
Show resolved
Hide resolved
|
Seems I will nominate you @MikeAlhayek for Formatting Award :) Mike implements IFormattable :) |
Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
Co-authored-by: Mike Alhayek <[email protected]>
MikeAlhayek
approved these changes
Sep 20, 2024
|
Nice work, thanks @davidpuplava |
|
/backport to release/2.0 |
|
Started backporting to release/2.0: https://github.com/OrchardCMS/OrchardCore/actions/runs/11021209008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16764
.GetSettingsinstead ofSettings.ToObjectSettings.ToObjectis used because I didn't know how to write tests for things like the Migrations to know if there is a problem that needs to be fixed.It looks like
Settings.ToObjectonly fails when the Settings object is a child JNode of Settings; when the settings object is rooted atSettingsthen I think the call works as expected.I didn't want to hold up this PR while I figure out how to test all the other places where
Settings.ToObjectis used. I'll work on that next.