Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDS-1016] fix: truncated text on sticky header table #832

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[NDS-1016] fix: truncated text on sticky header table #832

merged 2 commits into from
Sep 20, 2024

Conversation

kostasdano
Copy link
Collaborator

@kostasdano kostasdano commented Sep 20, 2024 •
edited by jira bot
Loading

Description

NDS-1016

  • Remove flexbox from cells in order for truncation to work.
  • Add default width for cells even when width is not provided in order for truncation to work.

@kostasdano kostasdano added the v5 This feature will be released on version 5 (next) label Sep 20, 2024
@kostasdano kostasdano requested a review from a team as a code owner September 20, 2024 10:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@kostasdano kostasdano merged commit df38749 into master Sep 20, 2024
13 of 15 checks passed
@kostasdano kostasdano deleted the fix/NDS-1016_truncated_text_on_sticky_header_table branch September 20, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsevdos tsevdos tsevdos approved these changes

Assignees
No one assigned
Labels
v5 This feature will be released on version 5 (next)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostasdano @tsevdos