fix: remove patch-package and add correct accessibility to SVG (#159)

* fix: remove patch-package * fix: remove patch-package * fix(svg): accessibility with title instead of alt text
Orfium · Jul 2, 2024 · 99670ac · 99670ac
1 parent c389441
commit 99670ac
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 19 deletions.
diff --git a/package.json b/package.json
@@ -63,7 +63,6 @@
     "jsdom": "^24.1.0",
     "jwt-encode": "^1.0.1",
     "lint-staged": "^12.4.1",
-    "patch-package": "^8.0.0",
     "prettier": "^2.6.2",
     "prettier-plugin-organize-imports": "^3.2.2",
     "react": "^18.1.0",
@@ -101,8 +100,7 @@
     "test": "vitest run",
     "test:watch": "node --experimental-vm-modules ./node_modules/.bin/jest --watch",
     "documentation:generate": "typedoc --out typeDocs src",
-    "documentation:up": "cd documentation && yarn start",
-    "postinstall": "patch-package"
+    "documentation:up": "cd documentation && yarn start"
   },
   "keywords": [
     "Orfium",

diff --git a/patches/vite-plugin-svgr+4.2.0.patch b/patches/vite-plugin-svgr+4.2.0.patch
diff --git a/src/ui/ErrorFallback/ErrorFallback.tsx b/src/ui/ErrorFallback/ErrorFallback.tsx
@@ -13,7 +13,7 @@ import {
 const ErrorFallback = ({ error, resetErrorBoundary }: any) => {
   return (
     <Wrapper role="alert">
-      <ErrorCover alt="Error fallback cover" />
+      <ErrorCover title="Error fallback cover" />
       <ContentWrapper>
         <div style={{ textAlign: 'center' }}>
           <Box>

diff --git a/src/ui/Navigation/components/GlobalNav/GlobalNav.tsx b/src/ui/Navigation/components/GlobalNav/GlobalNav.tsx
@@ -69,7 +69,7 @@ function GlobalNavLink(props: GlobalNavLinkProps) {
         return adminNavigationIsActive;
       }}
     >
-      <AdminIcon alt={adminButtonTooltipText} />
+      <AdminIcon title={adminButtonTooltipText} />
     </AppIconRRLink>
   );
 }

diff --git a/src/ui/TopBar/TopBar.tsx b/src/ui/TopBar/TopBar.tsx
@@ -13,7 +13,7 @@ export function TopBar({ utilitySlot, menuItems = [] }: TopBarProps) {
 
   return (
     <TopAppBarWrapper role="banner" aria-label="Top Application Banner">
-      <Logo alt={'Orfium logo'} height={28} width={28} />
+      <Logo title={'Orfium logo'} height={28} width={28} />
       <UserDefinedSlot>{topBarUtilitySlot || utilitySlot}</UserDefinedSlot>
       <UserSection>
         <UserMenu menuItems={menuItems} />