[DVP-207] feat: add fresh=true to request fresh membership #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panvourtsis
requested review from
johnecon,
mkarajohn and
Christos-Zacharopoulos
panvourtsis
had a problem deploying
to
review-118
GitHub Actions
Failure
|
SonarQube Quality Gate
|
Christos-Zacharopoulos
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a user when I get invited to an organisation and accept my invitation I should see an up to date memberships response.
Right now the response is cached and it’s invalidation may take 5-10 seconds leading to a broken experience. This leads the facade to return the previous response, if any, without the new organization from the invite.
On invitations, toolbox could send a parameter to sso-facade, say fresh=true on GET /memberships expecting a "fresh" version of the response. SSO-Facade should not fetch results from the cache (Dynamo). It should instead fetch the results directly from Auth0.
https://orfium.atlassian.net/browse/DVP-207
Screenshot
Test Plan
Tested on orfium one locally with invitation from auth0