Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to set engine for LedgerSubprovider for some reason #238

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Need to set engine for LedgerSubprovider for some reason #238

merged 1 commit into from
Sep 22, 2020

Conversation

mikeshultz
Copy link
Contributor

@mikeshultz mikeshultz commented Sep 22, 2020 •
edited
Loading

This appears to have been a bug in the original LedgerSubprovider form 0x? Anyway, tested locally and looks solid.

All the approves, mint, mintMultiple, and redeem all worked.

Ref: #21

@mikeshultz mikeshultz added bug Something isn't working dapp Relating to OUSD.com labels Sep 22, 2020
@mikeshultz mikeshultz self-assigned this Sep 22, 2020
sparrowDom
sparrowDom approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool find thanks

@sparrowDom sparrowDom merged commit aec7ef8 into master Sep 22, 2020
@sparrowDom sparrowDom deleted the mikeshultz/ledger-txsend-fix branch September 22, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparrowDom sparrowDom sparrowDom approved these changes

@shahthepro shahthepro Awaiting requested review from shahthepro

Assignees

@mikeshultz mikeshultz

Labels
bug Something isn't working dapp Relating to OUSD.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeshultz @sparrowDom