Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing violations #494

Closed
Zeitsperre opened this issue May 7, 2024 · 1 comment · Fixed by #507
Closed

Licensing violations #494

Zeitsperre opened this issue May 7, 2024 · 1 comment · Fixed by #507
Assignees

Comments

@Zeitsperre
Copy link
Contributor

Zeitsperre commented May 7, 2024

Briefly looking at some of the build failures, it occurred to me that a few of our dependencies are licensed for GPLv2-only and GPLv3-only. This isn't good.

Problematic packages:

  • pysheds (GPLv3)
  • unidecode (GPLv3)

Fixing this may mean that we pull a few processes. Hopefully not much.

@Zeitsperre Zeitsperre self-assigned this May 7, 2024
Zeitsperre added a commit that referenced this issue May 13, 2024
## Overview

This PR addresses points raised in #494 

Changes:

* Removed `pysheds` due to a licensing violation

## Related Issue / Discussion

https://www.apache.org/licenses/GPL-compatibility.html
@Zeitsperre
Copy link
Contributor Author

We might be able to substitute anyascii for unidecode. Worth exploring.

Zeitsperre added a commit that referenced this issue May 14, 2024
## Overview

This PR addresses issues raised in #494 

Changes:

* Replaced `unidecode` (GPLv2) with `anyascii` (MIT)
* Removed `pandoc`, `poppler`, and `tbb` from conda environment
dependencies

## Related Issue / Discussion

There are still some final issues with the licensing for `cartopy` which
changed from LGPL to BSD-3-Clause in version 0.23. This update will
force us to drop Python3.8. I'll address this in a new Pull Request.
Zeitsperre added a commit that referenced this issue May 14, 2024
## Overview

This PR fixes #494 

Changes:

* Upgraded Cartopy to v0.23.0 (BSD License)
* Added `yamllint` and `isort` to development deps and to linting
* Dropped support for Python3.8

## Additional Information

SciTools/cartopy#2285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant