Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast-forward cookiecutter, apply mamba v2.0 fix #29

Merged
merged 5 commits into from
Oct 2, 2024
Merged

fast-forward cookiecutter, apply mamba v2.0 fix #29

merged 5 commits into from
Oct 2, 2024

Conversation

Zeitsperre
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fast-forwards the cookiecutter
  • Adds a workaround for the mamba v2.0 bug in GitHub Workflows
  • Stages support for Python3.13
  • Workflows are now faster thanks to better use of caching

Does this PR introduce a breaking change?

No.

Other information:

mamba-org/setup-micromamba#225

@Zeitsperre Zeitsperre requested a review from coxipi October 2, 2024 14:43
@Zeitsperre Zeitsperre self-assigned this Oct 2, 2024
@coveralls
Copy link

coveralls commented Oct 2, 2024 •
edited
Loading

Coverage Status

coverage: 23.077%. remained the same
when pulling bf7216f on fast-forward
into 2a88896 on main.

coxipi
coxipi reviewed Oct 2, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
coxipi
coxipi reviewed Oct 2, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
coxipi
coxipi approved these changes Oct 2, 2024
View reviewed changes
Copy link

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was just unsure about the commented "python3.13" and new section py313

@Zeitsperre Zeitsperre merged commit c5e8e55 into main Oct 2, 2024
18 checks passed
@Zeitsperre Zeitsperre deleted the fast-forward branch October 2, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
CI docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @coxipi