RNMT-5719 Add preference to disable MacOS target #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoappereira
requested review from
andredestro,
EiyuuZack,
Chuckytuh,
cmfsotelo,
sandrarodrigues76 and
usernuno
and removed request for
a team
Chuckytuh
approved these changes
Dec 2, 2022
| @@ -14,6 +14,7 @@ | |||
| <preference name="target-device" value="handset" /> | |||
| <preference name="deployment-target" value="11.0" /> | |||
| <preference name="SwiftVersion" value="4.1" /> | |||
| <preference name="SupportMac" value="true" /> | |||
There was a problem hiding this comment.
I'm assuming an accompanying PR on the template will introduce the preference SupportMac with value false, right?
There was a problem hiding this comment.
Exactly, it will be added in our template!
andredestro
approved these changes
Dec 5, 2022
usernuno
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a preference called
SupportMacto enable/disable the MacOS target.By default, it is enabled.
Credits to @usernuno.
Platforms affected
iOS
Motivation and Context
Closes https://outsystemsrd.atlassian.net/browse/RNMT-5719
Testing
Created a local iOS Cordova project based on this cordova-ios branch and the .pbxproj was:
SupportMacis not setSupportMacis set with the valuetrueSupportMacis set with the valuefalseChecklist
(platform)if this change only applies to one platform (e.g.(android))