Linearly reference road width #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OvertureMaps/schema-wg#151 This is a commit by vcschapp@ that builds on Ola's work from the above- referenced issue. There are two changes to the schema: 1. Road "width" moves under the "road" property. 2. Road "width" is now linearly-referenced. The following are changes from Ola's previous work: 1. In keeping with our Parquet compatibility and tooling compatibility drive, there is no option for a scalar value for "width": it must now always be a non-empty array of rules. 2. I moved "width" under "road" because it's not obvious that it's a generalized property even for all types of segment, let alone across Overture, especially with the LR facet.
vcschapp
requested review from
jenningsanderson,
DavidKarlas,
bastiaanvanassche-tomtom,
AleksandraDebicka-TomTom,
TristanDiet-TomTom and
sanjibdutta1
sanjibdutta1
approved these changes
Feb 9, 2024
brad-richardson
approved these changes
Feb 12, 2024
bastiaanvanassche-tomtom
approved these changes
Feb 19, 2024
TristanDiet-TomTom
approved these changes
Feb 21, 2024
|
Merged it. For Schema TF, @DavidKarlas said Sanjib's approval is good for MSFT, and for Meta, @jwass said Brad's approval is good for Meta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables linear referencing of road width, addressing a known defect in the schema. It also moves the road
"width"property under the"road"property since, especially with LR, width is not an obviously generalized property cutting across the whole schema.We do not currently combobulate road with at all, so once this change is merged we shall have to.
Acknowledgements
This PR builds on Ola's work referenced in the below listed issue and her name is consequently kept on the commit.
compat
Reference
https://github.com/OvertureMaps/schema-wg/issues/151
Testing