Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the SQL files that contain the logic to map features between OSM tags and Overture values. These are added to the
task-force-docs
.Currently, the logic behind the base theme is a series of
SQL
files here that are assembled by a (perhaps hacky)render
script and then included in the Airflow DAG to create the base data from the daylight map distribution. Limitations include:render_queries.py
script before committing / pushing code.This PR moves these SQL files to the public
schema
repo. Advantages include:schema/task-force-docs
The biggest advantage here is that the actual SQL logic that creates a given release can be tied to a schema release version.
On the data-platform side, https://github.com/OvertureMaps/tf-data-platform/pull/158 alters the Airflow DAG to pull these SQL files from the
schema
repo before each run.Reference
List of relevant links to GitHub issues, PRs, and other documentation.
Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
The Airflow DAG for
base_theme_staging
reads the files from this PR.Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Documentation Website
(Doesn't affect the docs)
Docs preview for this PR.