Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename connectors to connector_ids #137

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Rename connectors to connector_ids #137

merged 3 commits into from
Mar 5, 2024

Conversation

brad-richardson
Copy link
Contributor

@brad-richardson brad-richardson commented Feb 29, 2024

Description

This renames the segment connectors property to connector_ids, which conforms to the relationship modeling schema decision.

Reference

  1. https://github.com/OvertureMaps/tf-transportation/issues/88
  2. https://github.com/OvertureMaps/schema-wg/blob/admin/decisions/adr-relationship-modeling.md

Testing

Updated relevant examples and counterexamples

Checklist

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  4. Update Docusaurus documentation, if an update is required.
  5. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Docs preview for this PR.

vcschapp
vcschapp previously approved these changes Mar 1, 2024
Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--    .-""-.
   ) (     )
  (   )   (
     /     )
    (_    _)                     0_,-.__
      (_  )_                     |_.-._/
       (    )                    |_--..\
        (__)                     |__--_/
     |''   ``\                   |
     |        \                  |      /b.
     |         \  ,,,---===?A`\  |  ,==y'
   ___,,,,,---==""\        |M] \ | ;|\ |>
           _   _   \   ___,|H,,---==""""bno,
    o  O  (_) (_)   \ /          _     AWAW/
                     /         _(+)_  dMM/
      \@_,,,,,,---=="   \      \\|//  MW/
--''''"                         ===  d/
                                    //
                                    ,'__________________________
   \    \    \     \               ,/~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         _____    ,'  ~~~   .-""-.~~~~~~  .-""-.
      .-""-.           ///==---   /`-._ ..-'      -.__..-'
            `-.__..-' =====\\\\\\ V/  .---\.
 PGMG                 ~~~~~~~~~~~~, _',--/_.\  .-""-.
                            .-""-.___` --  \|         -.__..-

gers/examples/python/match_classes.py Show resolved Hide resolved
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
vcschapp
vcschapp previously approved these changes Mar 1, 2024
Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-up approval.

sanjibdutta1
sanjibdutta1 previously approved these changes Mar 1, 2024
@vcschapp vcschapp dismissed stale reviews from bastiaanvanassche-tomtom, sanjibdutta1, and themself via 552d4dd March 5, 2024 15:51
@vcschapp vcschapp merged commit 1666de6 into dev Mar 5, 2024
2 checks passed
@vcschapp vcschapp deleted the connector_ids branch March 5, 2024 16:49
vcschapp added a commit that referenced this pull request Mar 12, 2024
* Rename connectors to connector_ids

* Update description

---------

Co-authored-by: Brad Richardson <[email protected]>
Co-authored-by: Victor Schappert <[email protected]>
jonahadkins pushed a commit that referenced this pull request Jul 12, 2024
* Rename connectors to connector_ids

* Update description

---------

Co-authored-by: Brad Richardson <[email protected]>
Co-authored-by: Victor Schappert <[email protected]>
jonahadkins pushed a commit that referenced this pull request Sep 7, 2024
* Rename connectors to connector_ids

* Update description

---------

Co-authored-by: Brad Richardson <[email protected]>
Co-authored-by: Victor Schappert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants