-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename connectors to connector_ids #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-richardson
requested review from
vcschapp,
bastiaanvanassche-tomtom and
sanjibdutta1
February 29, 2024 21:51
vcschapp
previously approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- .-""-.
) ( )
( ) (
/ )
(_ _) 0_,-.__
(_ )_ |_.-._/
( ) |_--..\
(__) |__--_/
|'' ``\ |
| \ | /b.
| \ ,,,---===?A`\ | ,==y'
___,,,,,---==""\ |M] \ | ;|\ |>
_ _ \ ___,|H,,---==""""bno,
o O (_) (_) \ / _ AWAW/
/ _(+)_ dMM/
\@_,,,,,,---==" \ \\|// MW/
--''''" === d/
//
,'__________________________
\ \ \ \ ,/~~~~~~~~~~~~~~~~~~~~~~~~~~~
_____ ,' ~~~ .-""-.~~~~~~ .-""-.
.-""-. ///==--- /`-._ ..-' -.__..-'
`-.__..-' =====\\\\\\ V/ .---\.
PGMG ~~~~~~~~~~~~, _',--/_.\ .-""-.
.-""-.___` -- \| -.__..-
vcschapp
previously approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-up approval.
sanjibdutta1
previously approved these changes
Mar 1, 2024
bastiaanvanassche-tomtom
previously approved these changes
Mar 5, 2024
vcschapp
dismissed stale reviews from bastiaanvanassche-tomtom, sanjibdutta1, and themself
via
March 5, 2024 15:51
552d4dd
bastiaanvanassche-tomtom
approved these changes
Mar 5, 2024
vcschapp
approved these changes
Mar 5, 2024
vcschapp
added a commit
that referenced
this pull request
Mar 12, 2024
* Rename connectors to connector_ids * Update description --------- Co-authored-by: Brad Richardson <[email protected]> Co-authored-by: Victor Schappert <[email protected]>
jonahadkins
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Rename connectors to connector_ids * Update description --------- Co-authored-by: Brad Richardson <[email protected]> Co-authored-by: Victor Schappert <[email protected]>
jonahadkins
pushed a commit
that referenced
this pull request
Sep 7, 2024
* Rename connectors to connector_ids * Update description --------- Co-authored-by: Brad Richardson <[email protected]> Co-authored-by: Victor Schappert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This renames the segment
connectors
property toconnector_ids
, which conforms to the relationship modeling schema decision.Reference
Testing
Updated relevant examples and counterexamples
Checklist
Documentation Website
Docs preview for this PR.