Delete primary
sub-property from division's local_type
#139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the business purpose and effect of the pull request.
This change deletes the
primary
sub-property from a division'slocal_type
property and deletes a redundant level of nesting.Before
After
Reference
List of relevant links to GitHub issues, PRs, and other documentation.
names
structure because the name of a feature is much more local and primary preferences should tend to even out, whereas withlocal_type
we would want to be able to have a single "national" policy to make the data programmatically friendly. But a single policy would tend to globally prefer one translation over another so we decided to drop "primary" instead.Testing
Brief description of the testing done for this change showing why you are confident it works as expected and does not introduce regressions. Provide sample output data where appropriate.
Updated examples and counterexamples.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.