Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transportation Destinations #176

Merged
merged 15 commits into from
Jul 24, 2024
Merged

Transportation Destinations #176

merged 15 commits into from
Jul 24, 2024

Conversation

ibnt1
Copy link
Contributor

@ibnt1 ibnt1 commented Apr 26, 2024

Description

Adds support for segment destinations as a top-level property.

These are intended to capture OSM destination=* tags on ways and destination_sign relations consolidated into a common schema.

Similar to the OSM destination tags on ways, destination property describes objects that are reached, when a the segment is being followed, but also includes references to the segments from which you need to transition to reach the destination, similar to the OSM destination_sign relations.

Reference

  1. https://github.com/OvertureMaps/tf-transportation/issues/117

Testing

Added new examples, tested.

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

@ibnt1 ibnt1 marked this pull request as ready for review April 26, 2024 02:53
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
brad-richardson
brad-richardson previously approved these changes May 7, 2024
Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm basically leaving this alone right now until the nesting discussion gets resolved in a principled way.... Ideally we can make a final decision on nesting and all related churn in transportation will stop.

schema/transportation/segment.yaml Outdated Show resolved Hide resolved
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
schema/transportation/segment.yaml Outdated Show resolved Hide resolved
schema/transportation/segment.yaml Show resolved Hide resolved
@ibnt1 ibnt1 requested a review from mojodna July 23, 2024 18:03
mojodna
mojodna previously approved these changes Jul 23, 2024
1 Outdated Show resolved Hide resolved
@jenningsanderson jenningsanderson merged commit 02d3354 into dev Jul 24, 2024
2 checks passed
@jenningsanderson jenningsanderson deleted the destinations branch July 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants