-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transportation Destinations #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibnt1
requested review from
vcschapp,
brad-richardson,
bastiaanvanassche-tomtom and
sanjibdutta1
April 26, 2024 02:53
brad-richardson
previously approved these changes
Apr 29, 2024
counterexamples/transportation/segment/road/bad-road-flags-duplicate-flag.json
Outdated
Show resolved
Hide resolved
brad-richardson
previously approved these changes
Apr 29, 2024
...es/transportation/segment/road/destinations/bad-road-destinations-missing-final_heading.yaml
Outdated
Show resolved
Hide resolved
...amples/transportation/segment/road/destinations/bad-road-destinations-empty-label-value.yaml
Outdated
Show resolved
Hide resolved
...rexamples/transportation/segment/road/destinations/bad-road-destinations-bad-label-type.yaml
Outdated
Show resolved
Hide resolved
bastiaanvanassche-tomtom
previously approved these changes
May 3, 2024
brad-richardson
previously approved these changes
May 7, 2024
vcschapp
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm basically leaving this alone right now until the nesting discussion gets resolved in a principled way.... Ideally we can make a final decision on nesting and all related churn in transportation will stop.
vcschapp
previously requested changes
May 30, 2024
...es/transportation/segment/road/destinations/bad-road-destinations-missing-final_heading.yaml
Outdated
Show resolved
Hide resolved
...rexamples/transportation/segment/road/destinations/bad-road-destinations-bad-label-type.yaml
Outdated
Show resolved
Hide resolved
...amples/transportation/segment/road/destinations/bad-road-destinations-empty-label-value.yaml
Outdated
Show resolved
Hide resolved
counterexamples/transportation/segment/road/destinations/bad-road-destinations-duplicate.yaml
Outdated
Show resolved
Hide resolved
vcschapp
reviewed
Jun 27, 2024
examples/transportation/segment/road/destinations/road-destinations.yaml
Outdated
Show resolved
Hide resolved
…segment instead of the 'to'.
ibnt1
dismissed stale reviews from brad-richardson and bastiaanvanassche-tomtom
via
July 9, 2024 01:05
e9f138c
ibnt1
requested review from
vcschapp,
bastiaanvanassche-tomtom and
brad-richardson
July 9, 2024 19:14
brad-richardson
previously approved these changes
Jul 23, 2024
PascalClarysse-TomTom
requested review from
PascalClarysse-TomTom
and removed request for
PascalClarysse-TomTom
July 23, 2024 15:39
PascalClarysse-TomTom
previously approved these changes
Jul 23, 2024
ibnt1
dismissed stale reviews from PascalClarysse-TomTom and brad-richardson
via
July 23, 2024 18:15
7accd7d
mojodna
previously approved these changes
Jul 23, 2024
brad-richardson
previously approved these changes
Jul 23, 2024
PascalClarysse-TomTom
previously approved these changes
Jul 24, 2024
jwass
reviewed
Jul 24, 2024
ibnt1
dismissed stale reviews from PascalClarysse-TomTom, brad-richardson, and mojodna
via
July 24, 2024 15:44
4af1cc2
jenningsanderson
approved these changes
Jul 24, 2024
jwass
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for segment destinations as a top-level property.
These are intended to capture OSM destination=* tags on ways and destination_sign relations consolidated into a common schema.
Similar to the OSM destination tags on ways, destination property describes objects that are reached, when a the segment is being followed, but also includes references to the segments from which you need to transition to reach the destination, similar to the OSM destination_sign relations.
Reference
Testing
Added new examples, tested.
Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Documentation Website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.