Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment subclass #180

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Segment subclass #180

merged 3 commits into from
Jul 24, 2024

Conversation

brad-richardson
Copy link
Contributor

@brad-richardson brad-richardson commented Apr 30, 2024

Description

The current segmentation process exclusively uses OSM's highway= tag during merging of segments. This results in segments that no longer distinguish the subparts. Here are some examples that contain two incompatible classes (sidewalk, crosswalk) which currently fallback to footway, causing the differentiating classes to be lost:
Screenshot 2024-04-30 at 4 47 42 PM

Service roads and footways are the most impacted and we can't fully capture the road network with our schema as it stands. The proposal is to add a new scope-able subclasses property.

Reference

  1. https://github.com/OvertureMaps/tf-transportation/issues/248
  2. https://wiki.overturemaps.org/display/PROJ/Footway+and+Service+Road+Segmentation+Error+Handling

Testing

Verified tests passed

Checklist

Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Docs preview for this PR.

@brad-richardson brad-richardson changed the title [WIP] Segment subclass Segment subclass Jun 12, 2024
@brad-richardson brad-richardson marked this pull request as ready for review June 12, 2024 02:47
@jenningsanderson jenningsanderson self-requested a review July 24, 2024 18:10
Copy link
Collaborator

@jenningsanderson jenningsanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 1 more stamp (implicit Meta approval from Brad)

@jenningsanderson jenningsanderson merged commit 8586b2f into dev Jul 24, 2024
2 checks passed
@jenningsanderson jenningsanderson deleted the segment-subclass branch July 24, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants