Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add num_floors_underground #217

Merged
merged 5 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions counterexamples/buildings/bad-floors-underground.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
id: overture:buildings:footprint:1234
type: Feature
geometry:
type: Polygon
coordinates: [[[0, 0], [0, 1], [1, 1], [1, 0], [0, 0]]]
properties:
theme: buildings
type: building
vcschapp marked this conversation as resolved.
Show resolved Hide resolved
version: 1
num_floors_underground: -1
ext_expected_errors:
- "[I#/properties/num_floors_underground] [S#/$defs/propertyDefinitions/featureUpdateTime/format] 'abc2023-02-22T23:55:01-08:00' is not valid 'date-time'"
1 change: 1 addition & 0 deletions examples/buildings/building-polygon.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ properties:
update_time: "2023-06-06T10:30:00-08:00"
height: 21.34
num_floors: 4
num_floors_underground: 1
subtype: transportation
class: parking
is_underground: false
Expand Down
5 changes: 5 additions & 0 deletions schema/buildings/defs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ shapeContainer:
Number of above-ground floors of the building or part.
type: integer
exclusiveMinimum: 0
num_floors_underground:
description: >-
Number of below-ground floors of the building or part.
type: integer
exclusiveMinimum: 0
min_height:
description: >-
The height of the bottom part of building in meters. Used if a building or part of building starts above the ground level.
Expand Down
Loading