Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admins] Add Area type and allow only Point on Locality #72

Merged
merged 5 commits into from
Nov 9, 2023

Commits on Nov 2, 2023

  1. [Admins] Remove mentioning disputed boundaries as missing feature

    This was added few weeks ago, didn't realise it was mentioned here...
    DavidKarlas committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e01e6d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f571c11 View commit details
    Browse the repository at this point in the history
  3. [Admins] Add Area type and allow only Point on Locality

    With new relations we can now add multiple different geometries to one admin, here we are changing modeling for localities to always have point and in case it also has polygon adds it via new Area type which references Locality via `localityId` property.
    DavidKarlas committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0e4c01d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Addressed PR comments, renamed Area to LocalityArea

    Also renamed `maritime` to `isMaritime` and moved to `defs.yaml` in `admins/`
    Also added to `locality.mdx` text mentioning where to get polygons, to help new comer faster understand this pretty important information when looking at admins :)
    DavidKarlas committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    db438c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Drop isMaritime from localityArea for now

    Tristan raised concern regarding what would landmass version of polygon represent, simplified area or not(because not simplified is very big and complex geometry) and all this can be calculated by user by removing Coastline from maritime Polygons...
    Hence let's have broader discussion over next few weeks which polygons we want to include in Overture...
    DavidKarlas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8cdf80c View commit details
    Browse the repository at this point in the history