Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spelling of cafeteria #86

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix: spelling of cafeteria #86

merged 2 commits into from
Dec 13, 2023

Conversation

JanCallewaert-TomTom
Copy link
Contributor

No description provided.

@JanCallewaert-TomTom JanCallewaert-TomTom changed the base branch from main to dev November 30, 2023 18:00
klayton-symbiosis
klayton-symbiosis suggested changes Dec 5, 2023
View reviewed changes
Copy link

@klayton-symbiosis klayton-symbiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change the second spelling (in the tree path)

@vcschapp vcschapp self-requested a review December 6, 2023 00:40
vcschapp
vcschapp requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history doesn't make sense to me - there are 23 commits to merge in the PR, but the description is perfunctory and suggests a change which should only require one very minimal commit ("fix: spelling of cafeteria").

Assuming the dev branch is the correct branch to target, I think you should ensure your local repo's commit history is closer to dev before creating the PR...

@JanCallewaert-TomTom JanCallewaert-TomTom force-pushed the users/callewaertjan-tomtom/cafeteria-spelling-fix branch from d0cff23 to 5991175 Compare December 7, 2023 18:32
@JanCallewaert-TomTom
Copy link
Contributor Author

The commit history doesn't make sense to me - there are 23 commits to merge in the PR, but the description is perfunctory and suggests a change which should only require one very minimal commit ("fix: spelling of cafeteria").

Assuming the dev branch is the correct branch to target, I think you should ensure your local repo's commit history is closer to dev before creating the PR...

I have rebased on dev. Should be fine now.

@RobSoetewey-TomTom RobSoetewey-TomTom merged commit 1aaa878 into dev Dec 13, 2023
2 checks passed
@RobSoetewey-TomTom RobSoetewey-TomTom deleted the users/callewaertjan-tomtom/cafeteria-spelling-fix branch December 13, 2023 16:13
@Dritte
Copy link
Contributor

Dritte commented Dec 13, 2023

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKarlas DavidKarlas DavidKarlas approved these changes

@vcschapp vcschapp vcschapp approved these changes

@klayton-symbiosis klayton-symbiosis klayton-symbiosis approved these changes

@Dritte Dritte Awaiting requested review from Dritte

@cbeddow cbeddow Awaiting requested review from cbeddow

@danbeeee danbeeee Awaiting requested review from danbeeee

@msftseanking msftseanking Awaiting requested review from msftseanking

@yuqin-msft yuqin-msft Awaiting requested review from yuqin-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JanCallewaert-TomTom @Dritte @DavidKarlas @vcschapp @klayton-symbiosis @RobSoetewey-TomTom