Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Transportation diagrams with dark/light theme and Overture color palette #94

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

vcschapp
Copy link
Collaborator

@vcschapp vcschapp commented Dec 9, 2023

Description

This change swaps out all the somewhat scrappy Transportation diagram images that I created back in August with improved versions courtesy of the Linux Foundation graphics team, with thanks to Nora for making this happen!

The images have the same substantive content as before, but style and usability is improved in the following ways:

  1. Dark mode is now properly supported. Before when you switched to dark mode, the diagrams got wrecked and were equal parts unreadable and ugly.
  2. Overture Maps Foundation color palette. In the previous iteration, I just picked some random colours for high contrast, but they clash a bit with the Overture palette. The new diagrams use the OMF palette.
  3. Subtle improvements. A few of the diagrams are just subtley cleaner and nicer than before.

Example

Here's a before and after comparison of the top diagram from the top of the Shape and Connectivity page. Note that beautiful smoother curve in the after picture!

Before

image

After

image

Testing

Locally ran docusaurus $ npm run build && npm run start and tested the docs website.

Here's the staging built docs website for this PR so you can test it yourself: https://dfhx9f55j8eg5.cloudfront.net/pr/94.

This commit replaces all the scrappy diagrams I created for the detailed
Transportation theme documentation pages with slightly improved versions
that follow the Overture Maps Foundation's colour palette. Thanks to
The Linux Foundation graphics team and LF's nanwar@ for this beautiful
improvement!
Copy link
Contributor

@brad-richardson brad-richardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀 Looks amazing!

Copy link
Collaborator

@jenningsanderson jenningsanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent!

Copy link
Contributor

@bastiaanvanassche-tomtom bastiaanvanassche-tomtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - a thing of beauty is a joy forever...

@RobSoetewey-TomTom RobSoetewey-TomTom merged commit 7cd9167 into dev Dec 13, 2023
2 checks passed
@RobSoetewey-TomTom RobSoetewey-TomTom deleted the transportation_better_docs branch December 13, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants