Add options for hash length and bare output to exe #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're at it, mind that you need not (and IMHO should not) to hardcode an ENCODED_LEN, as it can be dynamically calculated, check this function. As of today, the utility only permits salts up to 16 bytes and your solution keeps an upper limit, although increasing it. |
|
Could one of you bring the encoded calculation function to the code? Then we can approve this PR. |
|
Gonna do it as soon as I get home. |
|
Please resolve the conflicts. |
|
@alipha please resolve the conflicts, else your pull request will be closed |
|
My apologies for the lack of attention of this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw on khovratovich/Argon2#21 that it was requested to be able to have the argon2 utility be able to output only the hexadecimal of the hash, and I thought that was useful, so I implemented that (-r) along with outputting only your$argon2i$ ... encoded string (-e). I also thought it might be nice to generate different output hash lengths, so I added that too (-h length). A max length of 1024 seems a little large, but having a max at all seems a bit arbitrary.