fix(linux): improved container support #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #217 +/- ##
==========================================
- Coverage 68.79% 68.62% -0.18%
==========================================
Files 27 27
Lines 2519 2521 +2
Branches 774 771 -3
==========================================
- Hits 1733 1730 -3
+ Misses 457 450 -7
- Partials 329 341 +12 ☔ View full report in Codecov by Sentry. |
Austin BenchmarksRunning Austin benchmarks with Python 3.10.14 Benchmark SummaryComparison of dev against 3.6.0. The following scenarios show a statistically significant difference in performance between the two versions.
Benchmark ResultsWall time [sampling interval: 1]Wall time [sampling interval: 1]
Wall time [sampling interval: 10]Wall time [sampling interval: 10]
Wall time [sampling interval: 100]Wall time [sampling interval: 100]
Wall time [sampling interval: 1000]Wall time [sampling interval: 1000]
CPU time [sampling interval: 1]CPU time [sampling interval: 1]
CPU time [sampling interval: 10]CPU time [sampling interval: 10]
CPU time [sampling interval: 100]CPU time [sampling interval: 100]
CPU time [sampling interval: 1000]CPU time [sampling interval: 1000]
RSA keygen [sampling interval: 1]RSA keygen [sampling interval: 1]
RSA keygen [sampling interval: 10]RSA keygen [sampling interval: 10]
RSA keygen [sampling interval: 100]RSA keygen [sampling interval: 100]
RSA keygen [sampling interval: 1000]RSA keygen [sampling interval: 1000]
Full metrics [sampling interval: 1]Full metrics [sampling interval: 1]
Full metrics [sampling interval: 10]Full metrics [sampling interval: 10]
Full metrics [sampling interval: 100]Full metrics [sampling interval: 100]
Full metrics [sampling interval: 1000]Full metrics [sampling interval: 1000]
Multiprocess wall time [sampling interval: 1]Multiprocess wall time [sampling interval: 1]
Multiprocess wall time [sampling interval: 10]Multiprocess wall time [sampling interval: 10]
Multiprocess wall time [sampling interval: 100]Multiprocess wall time [sampling interval: 100]
Multiprocess wall time [sampling interval: 1000]Multiprocess wall time [sampling interval: 1000]
|
P403n1x87
force-pushed
the
fix/container-support
branch
from
2ebbe1b
to
cd66c47
Compare
We make use of the /proc/root of the procfs to improve the chances that we can infer the required information, such as the location of the runtime structure and the interpreter version from binaries pointed at by the actual process root. This is relevant for processes running inside containers, since their FS root does not coincide with the host root.
P403n1x87
force-pushed
the
fix/container-support
branch
from
cd66c47
to
dd0fd91
Compare
P403n1x87
commented
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We make use of the /proc/root of the procfs to improve the chances that we can infer the required information, such as the location of the runtime structure and the interpreter version from binaries pointed at by the actual process root. This is relevant for processes running inside containers, since their FS root does not coincide with the host root.
Alternate Designs
None considered
Regressions
We are changing the paths that are used to inspect binaries. This might have an impact in the non-containerised cased, albeit the greater generality should ensure that the new code works as intended for a wider range of scenarios. We also bail out early on a failed version inference (in fact, on fatal errors), which might introduce a degree of flakiness in tests.
Verification Process
...