Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repository to PHPCSStandards organisation #146

Closed
Potherca opened this issue Jan 25, 2022 · 15 comments · Fixed by #158
Closed

Move repository to PHPCSStandards organisation #146

Potherca opened this issue Jan 25, 2022 · 15 comments · Fixed by #158

Comments

@Potherca
Copy link
Member

As mentioned before in #113 it is desirable to move this project to an organization that has more contributors and higher visibility.

Currently PHPCSStandards looks like the best match.

This issue proposes to move the repository for this project from the Dealerdirect organisation to PHPCSStandards.

Opinions?

@Potherca
Copy link
Member Author

Potherca commented Feb 4, 2022

As this motion has been seconded by both other active maintainers, lets make the move!

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

The one thing we should still discuss about this - should the package also be renamed to phpcsstandards/....

The downside of that is that 1) the stats won't be retained and 2) it will be quite a while before all users have switched over.
The upside of it is that we won't be dependent on the DealerDirect organisation continuing to allow us to manage the package on Packagist.

@Potherca
Copy link
Member Author

Potherca commented Feb 9, 2022

My current thinking is (more or less) that we should rename to phpcsstandards with release v1.0.
It might be less worrisome that only the statistics for pre-1.0 will be lost that way 😁

Regarding renaming, we might want to take it one step further and go from Dealerdirect/phpcodesniffer-composer-installer to phpcsstandards/composer-installer (as the "phpcodesniffer" part is implied in "phpcsstandards").

@Potherca
Copy link
Member Author

Potherca commented Feb 9, 2022

Also... Do we have any reason for not pressing the "transfer" button right now?

image

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

My current thinking is (more or less) that we should rename to phpcsstandards with release v1.0. It might be less worrisome that only the statistics for pre-1.0 will be lost that way 😁

Fair enough, clean slate and all.

For the record, current stats are pretty impressive already:

image

Regarding renaming, we might want to take it one step further and go from Dealerdirect/phpcodesniffer-composer-installer to phpcsstandards/composer-installer (as the "phpcodesniffer" part is implied in "phpcsstandards").

I agree, sounds like a good plan. On that note, we can rename the repo to composer-installer as well after the move.

Also... Do we have any reason for not pressing the "transfer" button right now?

Go for it! I'll handle the accepting on the other end.

@GaryJones
Copy link
Contributor

we can rename the repo to composer-installer as well after the move.

Does GitHub auto-redirect on a change like that?

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

@Potherca
Copy link
Member Author

Potherca commented Feb 9, 2022

Also... Do we have any reason for not pressing the "transfer" button right now?

Go for it! I'll handle the accepting on the other end.

@jrfnl Looks like I'm not allowed:

You don’t have the permission to create public repositories on PHPCSStandards 

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

Also... Do we have any reason for not pressing the "transfer" button right now?

Go for it! I'll handle the accepting on the other end.

@jrfnl Looks like I'm not allowed:

You don’t have the permission to create public repositories on PHPCSStandards 

@Potherca Huh ? That sounds weird - In my view, a transfer request should be allowed to be initiated by any admin of a repo with the acceptance being the responsibility of the organisation on the other end (with a mail notifying them there is a transfer request to accept).

May be something weird on GH's end.

I'll give it a try myself. Didn't want to do that before as for "auditability/transparency" it is, of course, better if the transfer is done by multiple people showing that there is consensus about it.

As a side-note: I have already invited both you as well as @mjrider to the PHPCSStandards organisation, but looks like neither of you have accepted yet.

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

I'll give it a try myself.

Looks like that worked. Shall I rename the repo to `composer-installer straight away as well ?

@Potherca
Copy link
Member Author

Potherca commented Feb 9, 2022

Shall I rename the repo to `composer-installer straight away as well ?

Yes please, the sooner the better IMHO.

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

Shall I rename the repo to `composer-installer straight away as well ?

Yes please, the sooner the better IMHO.

Done!

@GaryJones
Copy link
Contributor

GaryJones commented Feb 9, 2022

I had this issue open before the change was made, and I can confirm that GitHub successfully redirected me back to this issue when reloading the page. 👍🏻

Suggest: close.

@jrfnl
Copy link
Member

jrfnl commented Feb 9, 2022

@GaryJones Thanks for confirming. The issue will automatically be closed when #158 gets merged, which updates the references to the repo location in all relevant places in the code base.

@jrfnl
Copy link
Member

jrfnl commented Feb 10, 2022

@mjrider Looks like I don't get a notification mail when an invite to an organisation is accepted. Could you please leave a note here when you have ? I will then add you to the "composer plugin admins" team, which should give you admin access to the repo again.

jrfnl added a commit to jrfnl/phpcs-variable-analysis that referenced this issue Feb 17, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue sirbrillig#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to Automattic/VIP-Coding-Standards that referenced this issue Feb 17, 2022
jrfnl added a commit to PHPCSStandards/PHPCSDevCS that referenced this issue Feb 17, 2022
jrfnl added a commit to PHPCSStandards/PHPCSDevTools that referenced this issue Feb 17, 2022
jrfnl added a commit to PHPCSStandards/PHPCSExtra that referenced this issue Feb 17, 2022
jrfnl added a commit to PHPCSStandards/PHPCSUtils that referenced this issue Feb 17, 2022
The `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is a non-dev requirement for PHPCSUtils.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit updates the installation instructions to handle this.
It also adds an info block suggesting how to handle this for external standards including PHPCSUtils.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue #146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to PHPCSStandards/PHPCSUtils that referenced this issue Feb 17, 2022
The `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is a non-dev requirement for PHPCSUtils.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit updates the installation instructions to handle this.
It also adds an info block suggesting how to handle this for external standards including PHPCSUtils.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue #146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to PHPCSStandards/PHPCSExtra that referenced this issue Feb 17, 2022
sirbrillig pushed a commit to sirbrillig/phpcs-variable-analysis that referenced this issue Feb 21, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue #146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution

Co-authored-by: jrfnl <[email protected]>
@jrfnl jrfnl closed this as completed in #158 Mar 5, 2022
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Apr 22, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Apr 22, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Apr 26, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue May 15, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jun 17, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jun 17, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jun 25, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 22, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Aug 7, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Aug 10, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Aug 12, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS.

As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run.

This commit:
* Adds the necessary configuration for that to the `composer.json` for this project.
* Adds the CLI command to set those permissions to the installation instructions for consumer projects.

Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146))

Refs:
* https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl added a commit to PHPCompatibility/PHPCompatibilityMagento that referenced this issue Sep 4, 2022
jrfnl added a commit to PHPCompatibility/PHPCompatibilityAll that referenced this issue Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants