Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnumeric Writer #1551

Open
MarkBaker opened this issue Jun 26, 2020 · 0 comments
Open

Gnumeric Writer #1551

MarkBaker opened this issue Jun 26, 2020 · 0 comments
Labels
pinned pinned issue to avoid them becoming stale writer/gnumeric Writer for Gnumeric spreadsheet files

Comments

@MarkBaker
Copy link
Member

MarkBaker commented Jun 26, 2020 •
edited by Progi1984
Loading

This is:

- [ ] a bug report
- [X] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

We have a Gnumeric Reader, but I was literally today years old when I realised that I'd never created a Writer for Gnumeric files: an oversight that should be corrected

https://www.jfree.org/jworkbook/download/gnumeric-xml.pdf
@MarkBaker MarkBaker added the writer/gnumeric Writer for Gnumeric spreadsheet files label Jun 29, 2020
@MarkBaker MarkBaker added the pinned pinned issue to avoid them becoming stale label Jul 15, 2020
oleibman added a commit to oleibman/PhpSpreadsheet that referenced this issue Jul 7, 2024
@oleibman
Html Writer Minor Fixes
10123c4 
While researching issue PHPOffice#1551, I came across some minor problems.

When a spreadsheet does not have a title, which is often the case for spreadsheets created with Excel (note that this is not the case for spreadsheets created with PhpSpreadsheet), if you try to save it as Html, it throws an exception. It will now use the sheet title of the active sheet as a title in this case.

When writing an Html spreadsheet using `useInlineCss(true)`, gridlines are not handled properly. This is addressed by adding `class=gridlines gridlinesp` to the cell's `td` tag, and by suppressing any border attributes which would be styled as `none #000000`. It would be unusual to turn off gridlines for specific cells, but that can still be accomplished by using `Border::BORDER_NONE` in conjunction with any color other than `#000000` - see new test `testHideSomeGridlines`.
@oleibman oleibman mentioned this issue Jul 7, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned pinned issue to avoid them becoming stale writer/gnumeric Writer for Gnumeric spreadsheet files
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarkBaker