Inserting new row causes some address to return "XFD" instead.

[brianwong3]

This is:

- [x ] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

Upon calling "insertNewRowBefore", the cell references should be updated correctly.

What is the current behavior?

Currently, after calling "insertNewRowBefore", any columns starting with "Y", and "Z" evaluates to "true" and PhpSpreadsheet sets the new column value to "AddressRange::MAX_COLUMN"

What features do you think are causing the issue

• Reader
• Writer
• Styles
• Data Validations
• [x ] Formula Calculations
• Charts
• AutoFilter
• Form Elements

Does an issue affect all spreadsheet file formats? If not, which formats are affected?

So far only XLSX has been tested.

Which versions of PhpSpreadsheet and PHP are affected?

PhpSpreadsheet v1.26.0

After some digging, the issue seems to be from

PhpSpreadsheet/src/PhpSpreadsheet/CellReferenceHelper.php

Line 120 in e7a0e80

$newColumn = ($newColumn > AddressRange::MAX_COLUMN) ? AddressRange::MAX_COLUMN : $newColumn;

[oleibman]

Confirmed, but this appears to be a bug in Php, not PhpSpreadsheet. I will attempt to open a ticket there. As far as I can tell, the code in question worked through PHP7.3, and became broken in PHP7.4.

[oleibman]

Actually, it is possible that PHP7.4 changed the way that column comparisons happened. I think we can probably fix this in PhpSpreadsheet after all.

[MarkBaker]

Hmmmm, that looks like my bad; it was a bugfix that targeted ensuring that row/column ranges didn't fall outside the Excel max rows/columns, rather than cell ranges; but looks like I may have introduced a new bug for cell ranges in doing so
It should be fairly easy to fix by comparing the index value before converting to a string column name