Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Skip adding a defined name if the sheet isn't found #1746

Closed
wants to merge 1 commit into from

Conversation

vhr
Copy link

@vhr vhr commented Dec 7, 2020

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

in case when in the xlsx file has unused range name and the library will throw a exception with the following message as below, every time when we try to read the file

You must specify a worksheet or a scope for a Named Range

skip adding a defined name if the sheet isn't found
@vhr vhr changed the title Skip adding a defined name if the sheet isn't found WIP: Skip adding a defined name if the sheet isn't found Dec 7, 2020
@oleibman
Copy link
Collaborator

oleibman commented Dec 7, 2020

I believe that PR #1742 accomplishes the same goal, in a manner consistent with how Excel operates.

@vhr vhr closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants