Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix for AND/OR/XOR #3287

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Minor Fix for AND/OR/XOR #3287

merged 4 commits into from
Jan 16, 2023

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Jan 9, 2023

These 3 fall into the set of functions where Excel treats string literals differently depending on whether they are passed to the function directly or as a cell reference. PhpSpreadsheet is updated to try to duplicate that logic. New tests are added. Some existing test results had to change as a result of this code change.

This is:

- [x] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests

Checklist:

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

These 3 fall into the set of functions where Excel treats string literals differently depending on whether they are passed to the function directly or as a cell reference. PhpSpreadsheet is updated to try to duplicate that logic. New tests are added. Some existing test results had to change as a result of this code change.
@oleibman
Copy link
Collaborator Author

oleibman commented Jan 9, 2023

I don't care about, and have no intention to act on, Scrutinizer's "complexity" message.

@oleibman oleibman merged commit ac5299b into PHPOffice:master Jan 16, 2023
@oleibman oleibman deleted the andorxor branch February 10, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants