Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved handling of @ format mask #3344

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Improved handling of @ format mask #3344

merged 1 commit into from
Feb 4, 2023

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Improved handling of @ format mask

With some limitations remaining:

  • Still doesn't work in section 4
  • Doesn't work correctly if there is an @ in quotes, not recognised as a literal

@MarkBaker MarkBaker force-pushed the Format-Masks_Improved-@ branch 2 times, most recently from bb861d7 to 97b3b21 Compare February 4, 2023 03:46
@MarkBaker
Improved handling of @ format mask
edc003a 
Note that it still doesn't work fully if in section 4
@MarkBaker MarkBaker merged commit 0f8f359 into master Feb 4, 2023
@MarkBaker MarkBaker deleted the Format-Masks_Improved-@ branch February 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker