Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Table AutoFilter dropdown icon for AutoFit column sizing #3358

Merged
merged 5 commits into from
Feb 12, 2023

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Feb 10, 2023

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

See Issue #3356

When a Worksheet has an AutoFilter, then we make allowance for the AutoFilter dropdown icon in the filter heading when calculating AutoFit column widths.

Because a Table can also have its own AutoFilter, we now have to allow for that possibility as well when calculating column width for AutoFit columns

…toFilter dropdown icon in the filter heading when calculating AutoFit column widths.

Because a Table can also have its own AutoFilter, we now have to allow for that possibility as well when calculating column width for AutoFit columns
@MarkBaker MarkBaker force-pushed the Issue-3356_AutoFit-for-Table-AutoFilter branch from f935c0b to 5742410 Compare February 10, 2023 22:30
@MarkBaker MarkBaker force-pushed the Issue-3356_AutoFit-for-Table-AutoFilter branch from 6250f43 to afa6450 Compare February 12, 2023 01:29
@MarkBaker MarkBaker marked this pull request as ready for review February 12, 2023 01:35
@MarkBaker MarkBaker merged commit ff5087c into master Feb 12, 2023
@MarkBaker MarkBaker deleted the Issue-3356_AutoFit-for-Table-AutoFilter branch February 12, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant