Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Formulae outside the filter range when reading with a filter are not always being identified #3474

Merged

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Issue #3473

When loading a file and accessing cells outside a filter range, we still check for shared formulae that may need to be used inside the filter range; so we test for the cell's f attribute; and if it is a shared formula then it's saved in the Shared Formula table so that it can be used when we encounter a cell inside the filter range that does use it.

However, in some cases (like this one) no f attribute was set and we need to check for the presence of an f child element with a shared attribute to indicate a Shared Formula that needs saving in the Shared Formula table.

…ill check for shared formulae that may need to be used inside the filter range; so we test for the cell's f attribute.

However, in some cases this attribute isn't set and we need to check for the presence of an f child element with a shared attribute
… instance array, rather than using a simple nested array. This should be better for memory usage; and when we can apply readonly to object properties, then we can make the properties readonly public, eliminate the getters in the SharedFormula class
@MarkBaker MarkBaker merged commit c034e3c into master Mar 22, 2023
@MarkBaker MarkBaker deleted the Issue-3473_Shared-Formula-Chunked-Read-no-attribute-set branch March 22, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant