Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow color palette index values in number format masks #3512

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Apr 5, 2023

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Issue #3511

We've never supported colour palette references in number format masks before; it's about time that we did

@MarkBaker MarkBaker force-pushed the Issue-3511_NumberFormat-colour-indexed-palette branch from 04afee1 to c5fb58f Compare April 6, 2023 01:41
@MarkBaker MarkBaker merged commit 5ef48e9 into master Apr 7, 2023
@MarkBaker MarkBaker deleted the Issue-3511_NumberFormat-colour-indexed-palette branch April 7, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant