Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula Misidentifying Text as Cell After Insertion/Deletion #3915

Merged
merged 3 commits into from
Mar 1, 2024

Commits on Feb 22, 2024

  1. Formula Misidentifying Text as Cell After Insertion/Deletion

    Fix PHPOffice#3907. After row/column insertion/deletion, PhpSpreadsheet updates formulas which include cells which have moved. However, it can mis-identify cell addresses within the formula. Examples:
    - `=SUM(A2,'F1 (SETTINGS)'!A1:B1)` It identifes F1 as a cell address.
    - `=SUM(A2,'x F1 (SETTINGS)'!A1:B1)` It identifes F1 as a cell address. (This looks the same as the above, but, for technical reasons, it's different.)
    - `=SUM(A2,definedname1A1)` It identifes A1 as a cell address.
    - Sheet names in formulas are compared case-sensitively, and should be compared insensitively. This can make a difference if the formula includes its own sheet name, e.g. on sheet `Data`, formula `=SUM(DATA!A1:A2)` might have to change, but it will not do so with the existing logic.
    
    The defined name part is fairly straightforward. The regular expressions that identify a cell address just have to be a bit more robust. It was doing a negative look-behind for an alphabetic character or dollar sign; underscore, period, and digits, all of which can be part of a defined name, need to be added to that list.
    
    The other situations need a bit of a kludge, but not one so bad that I'm ashamed of it. The formulas will be altered before analysis so that sheet names are replaced with Unicode FFFD (sheetname does not match current sheet), FFFC (sheetname, enclosed in apostrophes, matches current sheet), and FFFB (sheetname, not enclosed in apostrophes, matches current sheet). This prevents the existing regular expressions from finding a cell address within a sheet name, and makes it easy to restore the original, with or without apostrophes, when the sheet name matches the current sheet and the cell(s) which it qualifies have to be changed.
    
    Tests are added for all the situations mentioned above. No existing tests required changes.
    oleibman committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a096fcc View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    4a459e0 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    oleibman committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c51ec67 View commit details
    Browse the repository at this point in the history