Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Not Output Alignment and Protection for Conditional Formats #4027

Merged
merged 2 commits into from
May 19, 2024
Merged

Do Not Output Alignment and Protection for Conditional Formats #4027

merged 2 commits into from
May 19, 2024

Commits on May 14, 2024

  1. Do Not Output Alignment and Protection for Conditional Formats 

    Fix PHPOffice#4025. With Conditional Formatting, Excel can change Font, Fill, Borders, and NumberFormat. It does not support Alignment nor Protection, at least not natively. This PR removes all code supporting Conditional Alignment or Protection from Xlsx and Xls Writer. Attached to the issue report is a spreadsheet where a conditionally formatted merged cell shows its value twice when Alignment is included with the Conditional Style; it is fixed by this PR. It is not entirely certain which particular combination of CF, Alignment, Merge, AutoFilter, and right-to-left sheet alignment trigger this problem. I am sure that it shows up for Vertical Alignment Center, and I am sure that Xls Writer (which is somewhat buggy anyhow regarding CF support - see issue PHPOffice#3403) has the same problem. The now-unused Xls code is commented out rather than deleted, for documentation purposes.
    @oleibman
    oleibman committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fe2fc36 View commit details
    Browse the repository at this point in the history

  2. Remove 2 Unneeded Statements

    @oleibman
    oleibman committed May 14, 2024
    Configuration menu
    Copy the full SHA
    40adbfe View commit details
    Browse the repository at this point in the history