Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dompdf and Php8.4 #4165

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Dompdf and Php8.4 #4165

merged 1 commit into from
Sep 8, 2024

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Sep 8, 2024

Lots of deprecation messages in nightly test suite. 8.4 is already in beta; the messages are a major distraction at this stage. Suppress them until Dompdf is fixed.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • temporary testing assistance

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Lots of deprecation messages. They are a major distraction at this stage. Suppress them until Dompdf is fixed.
@oleibman oleibman added this pull request to the merge queue Sep 8, 2024
Merged via the queue into PHPOffice:master with commit 3815843 Sep 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant