Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix print area parser for XLSX reader #734

Closed
wants to merge 3 commits into from
Closed

Fix print area parser for XLSX reader #734

wants to merge 3 commits into from

Conversation

guillaume-ro-fr
Copy link
Contributor

@guillaume-ro-fr guillaume-ro-fr commented Oct 22, 2018 •
edited
Loading

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

See #733

@guillaume-ro-fr
Fix print area parser for XLSX reader
4a4d49f 
XLSX workbook references may not contains quotes in print area

Fix PHPOffice#733
@guillaume-ro-fr
Add Tests
a6bfe8a
@PowerKiKi PowerKiKi closed this in fdc224a Oct 28, 2018
@PowerKiKi
Copy link
Member

Thanks !

@guillaume-ro-fr guillaume-ro-fr deleted the fix_733 branch October 28, 2018 17:42
guillaume-ro-fr added a commit to guillaume-ro-fr/PhpSpreadsheet that referenced this pull request Jun 12, 2019
@guillaume-ro-fr
Fix print area parser for XLSX reader
c98dc07 
XLSX workbook references may not contains quotes in print area

Fixes PHPOffice#733
Fixes PHPOffice#734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaume-ro-fr @PowerKiKi