Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement RATE algorithm from ODFF #848

Closed

Conversation

markkimsal
Copy link

This is:

- [*] a bugfix

Fixes #324

Implement the ODFF algorithm for RATE() from LibreOffice. Add test data that tests floating point $nper.

@markkimsal
Copy link
Author

The scrutinizer checks is flagging too many things as unused code.

$found = false
while (!$found) {
  if ($check) {
      $found =true;
  }
}

It says that $found=true is unused. That and a few other variables that are definitely not unused.

@stale
Copy link

stale bot commented Mar 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Mar 16, 2019
@MarkBaker MarkBaker removed the stale label Mar 17, 2019
@stale
Copy link

stale bot commented May 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label May 16, 2019
@stale stale bot closed this May 23, 2019
oleibman added a commit to oleibman/PhpSpreadsheet that referenced this pull request Jul 22, 2024
Suggested by PR PHPOffice#848 from @markkimsal. The RATE calculation had already been corrected, so that part of the PR was unnecessary, however one of the tests included a floating point value for Number of Periods, which Excel permits. PhpSpreadsheet till now expected that parameter to be an integer. This is trivially changed with some tests added.
@oleibman
Copy link
Collaborator

Superseded by 4107.

@oleibman oleibman removed the stale label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

RATE function doesn't work
3 participants