refactor: refactored the positioning system of the toolbar in the "following". #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"following".
- Refactord isExistoolbar() to get rid of deprecated code
(i.e., `activeLeaf`), and to simplify the code.
- Refactor the way the toolbar's position is calculated for the
"following" mode, to make sure the toolbar:
- Is always visible, even when we the user selects the last
line in the editor.
- Never overflows over the File Explorer of the Outline.
"following".
- Refactord isExistoolbar() to get rid of deprecated code
(i.e., `activeLeaf`), and to simplify the code.
- Refactor the way the toolbar's position is calculated for the
"following" mode, to make sure the toolbar:
- Is always visible, even when we the user selects the last
line in the editor.
- Never overflows over the File Explorer of the Outline.
|
Thank you for your work. There seems to be a positioning issue with my computer; the toolbar keeps overflowing off the screen. We'll hold off on merging branches until it's resolved. More improvements to come. |
Can you elaborate more please, what do you mean off screen? like outside of Obsidian's window completely? and can you please make sure to disable any plugins or themes that might interfere with your testing (you could use Obsidian sandbox vault). |
"following".
- Refactord isExistoolbar() to get rid of deprecated code
(i.e., `activeLeaf`), and to simplify the code.
- Refactor the way the toolbar's position is calculated for the
"following" mode, to make sure the toolbar:
- Is always visible, even when we the user selects the last
line in the editor.
- Never overflows over the File Explorer or the Outline.
Since getModestate() doesn't really get the mode state but rather returns whether the MarkdownView mode state is "source" or not, I renamed it to isSource(), and simplified the function in the process.
|
it looks a bit more normal, but the following list of tests will help you to determine if you have the same problem:
|
s4my
force-pushed
the
refactor/position
branch
4 times, most recently
from
82e1f53
to
09e6246
Compare
|
Hi @cumany, thank you for the detailed feedback, I fixed all the issues you mentioned above in this new commit. If you need me to make any further changes feel free to tell. |
s4my
force-pushed
the
refactor/position
branch
4 times, most recently
from
b38e265
to
e0df83d
Compare
position is set to "following".
- Refactored isExistoolbar() to get rid of deprecated code
(i.e., `activeLeaf`), and to simplify the code.
- Refactor the way the toolbar's position is calculated for the
"following" mode, to make sure the toolbar:
- Is always visible, even when we the user selects the last
or first line in the editor.
- To try not to overflow over the File Explorer or the Outline.
- Refactored getModestate() into isSource().
Since getModestate() doesn't really get the mode state but rather
returns whether the MarkdownView mode state is "source" or not, I
renamed it to isSource(), and simplified the function in the process.
|
Good job. It was perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the way the toolbar's position is calculated for the "following" mode to make sure the toolbar:
Refactord isExistoolbar() to get rid of deprecated code (i.e.,
activeLeaf), and to simplify the code.Refactored
getModestate()intoisSource(): sincegetModestate()doesn't really get the mode state, but rather returns whether the MarkdownView mode state is "source" or not, I renamed it toisSource()to reflect just that, and simplified the function implementation in the process.