Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tentative dependencies for KNP #43

Merged
merged 14 commits into from
Apr 11, 2020
Merged

Tentative dependencies for KNP #43

merged 14 commits into from
Apr 11, 2020

Conversation

KoichiYasuoka
Copy link
Contributor

@KoichiYasuoka KoichiYasuoka commented Apr 11, 2020 •
edited
Loading

Include one POS that has been missing, and try to include DEP for spaCy.

@KoichiYasuoka
Copy link
Contributor Author

Umm, flake8 says that 'knp_dependency_parser' is too complex (21)...

@tamuhey tamuhey self-requested a review April 11, 2020 10:46
@tamuhey
Copy link
Contributor

tamuhey commented Apr 11, 2020

Please add test

@tamuhey
Copy link
Contributor

tamuhey commented Apr 11, 2020

Thank you for your effort!

@tamuhey tamuhey merged commit d7e7b3b into PKSHATechnology-Research:master Apr 11, 2020
tamuhey
tamuhey approved these changes Apr 11, 2020
View reviewed changes
camphr/pipelines/knp/dependency_parser.py Show resolved Hide resolved
camphr/pipelines/knp/dependency_parser.py Outdated Show resolved Hide resolved
@tamuhey tamuhey added the enhancement New feature or request label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamuhey tamuhey tamuhey approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoichiYasuoka @tamuhey