-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper treatment of PUNCTs for KNP #48
Proper treatment of PUNCTs for KNP #48
Conversation
括弧始-PUNCTs are not suitable for head tokens in Universal Dependencies.
Oops, "build (juman)" has failed. How do I do? |
I'm vague why JUMAN treats "(※" as single midashi with two tokens... |
OK, now I understand that "(※" is treated as two tokens by JUMAN, and as single 顔文字 by KNP.
|
Thank you for your contribution! |
I think test_knp.py already includes very good example "(※" for this PR. It was very hard task for me to pass the test "(※" with 全角, and I got it. |
I think |
Thank you very much, @KoichiYasuoka! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@KoichiYasuoka I've publishe new version of camphr, so please check it out. |
括弧始-PUNCTs, such as ”(" "「" "『" and so on, are not suitable for head tokens in Universal Dependencies.