Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for サ変 of KNP #56

Merged
merged 2 commits into from
May 26, 2020

Conversation

KoichiYasuoka
Copy link
Contributor

Inside _get_child_dep(c), pos for 名詞,サ変名詞 is changed into VERB when it is followed by AUX. So now I think that _get_dep(tag[0]) should be done after _get_child_dep(c).

@tamuhey
Copy link
Contributor

tamuhey commented May 26, 2020

Thanks for your contribution again!
Could you add some examples as tests that is improved by this PR?

@KoichiYasuoka
Copy link
Contributor Author

「地震で半壊した家屋」 is added to test_dependency_parser.py and all checks have passed.

@tamuhey
Copy link
Contributor

tamuhey commented May 26, 2020

Thanks!

@tamuhey tamuhey self-requested a review May 26, 2020 11:38
@tamuhey tamuhey merged commit 927d0f9 into PKSHATechnology-Research:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants