Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

形容詞接頭辞 into PART #63

Merged
merged 4 commits into from
Jul 14, 2020
Merged

形容詞接頭辞 into PART #63

merged 4 commits into from
Jul 14, 2020

Conversation

KoichiYasuoka
Copy link
Contributor

イ形容詞接頭辞 and ナ形容詞接頭辞 should have been PART not NOUN.

@KoichiYasuoka
Copy link
Contributor Author

May I add a test "超重くて不完全" in test_dependency_parser.py?

@tamuhey
Copy link
Contributor

tamuhey commented Jul 14, 2020

May I add a test "超重くて不完全" in test_dependency_parser.py?

Yes, thanks!

@tamuhey tamuhey self-requested a review July 14, 2020 06:22
@KoichiYasuoka
Copy link
Contributor Author

It's OK!
deplacy

tamuhey
tamuhey approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@tamuhey tamuhey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tamuhey tamuhey merged commit 0bc361b into PKSHATechnology-Research:master Jul 14, 2020
@tamuhey
Copy link
Contributor

tamuhey commented Jul 14, 2020

Thank you so much, @KoichiYasuoka san!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamuhey tamuhey tamuhey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoichiYasuoka @tamuhey