Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(buffer): refactor buffer #101

Merged
merged 6 commits into from
Feb 7, 2023
Merged

refactor(buffer): refactor buffer #101

merged 6 commits into from
Feb 7, 2023

Conversation

rockmagma02
Copy link
Contributor

refactor(buffer): refactor buffer

  • delete the old Buffer
  • add abstractclass BaseBuffer
  • add OnpolicyBuffer, VectorOnpolicyBuffer, OffpolicyBuffer, VectorOffpolicyBuffer

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Gaiejj
Gaiejj previously approved these changes Feb 7, 2023
View reviewed changes
zmsn-2077
zmsn-2077 reviewed Feb 7, 2023
View reviewed changes
tests/test_buffer.py Outdated Show resolved Hide resolved
@zmsn-2077 zmsn-2077 self-requested a review February 7, 2023 18:45
friedmainfunction
friedmainfunction approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@friedmainfunction friedmainfunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@rockmagma02 rockmagma02 merged commit 0dbb399 into PKU-Alignment:dev Feb 7, 2023
@rockmagma02 rockmagma02 deleted the dev-buffer branch February 7, 2023 19:02
zmsn-2077 pushed a commit that referenced this pull request Feb 8, 2023
@rockmagma02 @zmsn-2077
refactor(buffer): refactor buffer (#101)
42282d6
@zmsn-2077 zmsn-2077 added the enhancement New feature or request label Feb 8, 2023
@zmsn-2077 zmsn-2077 added the codestyle update codestyple label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmsn-2077 zmsn-2077 zmsn-2077 approved these changes

@friedmainfunction friedmainfunction friedmainfunction approved these changes

@Gaiejj Gaiejj Gaiejj left review comments

Assignees
No one assigned
Labels
codestyle update codestyple enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rockmagma02 @zmsn-2077 @friedmainfunction @Gaiejj