Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(env): delete local safety-gymnaisum dependence #102

Merged
merged 9 commits into from
Feb 8, 2023

Conversation

rockmagma02
Copy link
Contributor

build(env): delete safety-gymnaisum local dependence

Motivation and Context

Safety-gymnaisum already can be downloaded from pypi, This pr delete safety-gymnaisum local dependence.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful review, I agree with these changes.

@rockmagma02 rockmagma02 merged commit fcde904 into PKU-Alignment:dev Feb 8, 2023
@rockmagma02 rockmagma02 deleted the dev-dependence branch February 8, 2023 09:31
@zmsn-2077 zmsn-2077 added environment Something related to the RL environment dependency Something related to package dependencies codestyle update codestyple labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codestyle update codestyple dependency Something related to package dependencies environment Something related to the RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants