Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change architecture of omnisafe #121

Merged
merged 40 commits into from
Feb 23, 2023

Conversation

rockmagma02
Copy link
Contributor

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@rockmagma02 rockmagma02 changed the title Dev refactor refactor: change arch of omnisafe Feb 23, 2023
@rockmagma02 rockmagma02 changed the title refactor: change arch of omnisafe refactor: change architecture of omnisafe Feb 23, 2023
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077 zmsn-2077 merged commit 0bb56fa into PKU-Alignment:dev Feb 23, 2023
muchvo referenced this pull request in muchvo/omnisafe Mar 14, 2023
refactor: change architecture of omnisafe (PKU-MARL#121)
zmsn-2077 pushed a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
zmsn-2077 pushed a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
zmsn-2077 pushed a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants