-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README.md #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
README.md
Outdated
) | ||
custom_cfgs = { | ||
'train_cfgs': { | ||
'total_steps': 1000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'total_steps': 1000000, | |
'total_steps': 1048576, |
README.md
Outdated
'vector_env_nums': 1, | ||
}, | ||
'algo_cfgs': { | ||
'update_cycle': 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'update_cycle': 1000, | |
'update_cycle': 1024, |
examples/train_from_custom_dict.py
Outdated
@@ -30,7 +31,8 @@ | |||
) | |||
custom_cfgs = { | |||
'train_cfgs': { | |||
'total_steps': 1000, | |||
'total_steps': 1000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'total_steps': 1000000, | |
'total_steps': 1048576, |
examples/train_from_custom_dict.py
Outdated
@@ -30,7 +31,8 @@ | |||
) | |||
custom_cfgs = { | |||
'train_cfgs': { | |||
'total_steps': 1000, | |||
'total_steps': 1000000, | |||
'vector_env_nums': 1, | |||
}, | |||
'algo_cfgs': { | |||
'update_cycle': 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'update_cycle': 1000, | |
'update_cycle': 1024, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
docs: update README.md
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)