Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #149

Merged
merged 6 commits into from
Mar 14, 2023
Merged

docs: update README.md #149

merged 6 commits into from
Mar 14, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Mar 14, 2023

Description

docs: update README.md

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
)
custom_cfgs = {
'train_cfgs': {
'total_steps': 1000000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'total_steps': 1000000,
'total_steps': 1048576,

README.md Outdated
'vector_env_nums': 1,
},
'algo_cfgs': {
'update_cycle': 1000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'update_cycle': 1000,
'update_cycle': 1024,

@@ -30,7 +31,8 @@
)
custom_cfgs = {
'train_cfgs': {
'total_steps': 1000,
'total_steps': 1000000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'total_steps': 1000000,
'total_steps': 1048576,

@@ -30,7 +31,8 @@
)
custom_cfgs = {
'train_cfgs': {
'total_steps': 1000,
'total_steps': 1000000,
'vector_env_nums': 1,
},
'algo_cfgs': {
'update_cycle': 1000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'update_cycle': 1000,
'update_cycle': 1024,

Copy link
Collaborator

@friedmainfunction friedmainfunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit b5f785e into PKU-Alignment:dev Mar 14, 2023
zmsn-2077 pushed a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
zmsn-2077 pushed a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
zmsn-2077 pushed a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
zmsn-2077 pushed a commit that referenced this pull request Mar 14, 2023
zmsn-2077 pushed a commit that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants