Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update github workflow #156

Merged
merged 16 commits into from
Mar 18, 2023
Merged

chore: update github workflow #156

merged 16 commits into from
Mar 18, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Mar 17, 2023

Description

Support different version of test in workflow

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@ba48512). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 3e0b050 differs from pull request most recent head 976dbbf. Consider uploading reports for the commit 976dbbf to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #156   +/-   ##
======================================
  Coverage       ?   83.97%           
======================================
  Files          ?       79           
  Lines          ?     3595           
  Branches       ?        0           
======================================
  Hits           ?     3019           
  Misses         ?      576           
  Partials       ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gaiejj Gaiejj changed the title chore: update ci.yaml chore: update github workflow Mar 17, 2023
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@friedmainfunction friedmainfunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 5068262 into PKU-Alignment:dev Mar 18, 2023
@Gaiejj Gaiejj deleted the dev-action branch March 18, 2023 02:02
zmsn-2077 pushed a commit that referenced this pull request Mar 19, 2023
zmsn-2077 pushed a commit that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants